bpo-39041: Add GitHub Actions support#17594
Conversation
brettcannon
left a comment
There was a problem hiding this comment.
Should make sure to add doc-building workflow. I would also build against -latest for the OSs. And I think you might be able to use ${runs-on} as the title so it states the OS that way.
|
I changed the VM images to "latest", but it still seems best to have static labels. I also added the coverage test run after we know the Ubuntu tests have passed, but I don't know that we'll want the extra delay. Maybe if I split it into a separate check we can make the coverage run optional? We'll have to merge this one first though. Once I get the docs workflow in then we can do that and iterate on the coverage run. |
|
Yeah, I would split the coverage run out as a separate thing as we don't rely on it to prevent coverage slippage. |
|
From my other PR (where I've enabled the builds), it looks like this: |
Disable C coverage step. Attempt to fix Python coverage step
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
(cherry picked from commit a76ba36) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-17868 is a backport of this pull request to the 3.8 branch. |
|
GH-17869 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit a76ba36) Co-authored-by: Steve Dower <steve.dower@python.org>
https://bugs.python.org/issue39041