Skip to content

bpo-38382: Document the early-out behavior for a zero #17037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhettinger merged 1 commit into from
Nov 7, 2019
Merged

bpo-38382: Document the early-out behavior for a zero #17037

rhettinger merged 1 commit into from
Nov 7, 2019

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Nov 3, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.8 labels Nov 3, 2019
taleinat
taleinat approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhettinger rhettinger merged commit 7f46049 into python:master Nov 7, 2019
@rhettinger rhettinger deleted the harmonic_mean_zero branch November 7, 2019 05:50
@miss-islington
Copy link
Contributor

miss-islington commented Nov 7, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 7, 2019

GH-17078 is a backport of this pull request to the 3.8 branch.

rhettinger added a commit that referenced this pull request Nov 7, 2019
@miss-islington @rhettinger
bpo-38382: Document the early-out behavior for a zero (GH-17037) (GH-…
6b66dc3 
…17078)

(cherry picked from commit 7f46049)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
tim-one
tim-one reviewed Nov 7, 2019
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@rhettinger
bpo-38382: Document the early-out behavior for a zero (pythonGH-17037)
db08598
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@rhettinger @shihai1991
bpo-38382: Document the early-out behavior for a zero (pythonGH-17037)
2081056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-one tim-one tim-one left review comments

@taleinat taleinat taleinat approved these changes

@stevendaprano stevendaprano Awaiting requested review from stevendaprano

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhettinger @miss-islington @bedevere-bot @taleinat @tim-one @the-knights-who-say-ni