bpo-32856: Optimize the assignment idiom in comprehensions.#16814
Merged
serhiy-storchaka merged 12 commits intopython:masterfrom Feb 12, 2020
Merged
Conversation
Now `for y in [expr]` in comprehensions is so fast as a simple assignment `y = expr`.
scoder
reviewed
Jan 8, 2020
Contributor
scoder
left a comment
There was a problem hiding this comment.
I don't have an opinion on the general feature, so just a few comments.
| ============= | ||
|
|
||
| * Optimized the idiom for assignment a temporary variable in comprehensions. | ||
| Now ``for y in [expr]`` in comprehensions is so fast as a simple assignment |
Contributor
There was a problem hiding this comment.
"as fast as" (also in news file)
Member
Author
There was a problem hiding this comment.
Done. Thank you.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
for y in [expr]in comprehensions is so fast as a simple assignmenty = expr.Unlike to the
:=operator this idiom does not leak a variable to the outer scope.https://bugs.python.org/issue32856