bpo-38353: Fix calculate_argv0_path() for symlinks#16549
Merged
vstinner merged 1 commit intopython:masterfrom Oct 3, 2019
vstinner:argv0_symlink
Merged
bpo-38353: Fix calculate_argv0_path() for symlinks#16549vstinner merged 1 commit intopython:masterfrom vstinner:argv0_symlink
vstinner merged 1 commit intopython:masterfrom
vstinner:argv0_symlink
Conversation
calculate_argv0_path() must read argv0_path link, not read program_full_path link.
Member
Author
|
This change only affects macOS ("#ifdef WITH_NEXT_FRAMEWORK"). |
Member
Author
|
The bug is that on macOS, readlink() is called on program_full_path (previously known as "progpath"), instead of argv0_path. The change likely has no effect on practice. I don't expect program_full_path nor argv0_path to be symlinks on macOS. The bug is quite old, it was introduced by: Previously, at the first readlink() call, argv0_path was equal to progpath: Previously = the following commit: |
Member
Author
|
Since Python is working well since 2001 on macOS, I don't think that it's worth it to backport this change to Python 3.8 and older. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
calculate_argv0_path() must read argv0_path link, not read program_full_path link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate_argv0_path() must read argv0_path link, not read
program_full_path link.
https://bugs.python.org/issue38353