bpo-38163: Child mocks detect their type as sync or async#16471
Merged
lisroach merged 6 commits intopython:masterfrom Sep 30, 2019
Merged
bpo-38163: Child mocks detect their type as sync or async#16471lisroach merged 6 commits intopython:masterfrom
lisroach merged 6 commits intopython:masterfrom
Conversation
Contributor
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
I'm having trouble backporting to |
Contributor
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry @lisroach, I had trouble checking out the |
lisroach
added a commit
to lisroach/cpython
that referenced
this pull request
Sep 30, 2019
…onGH-16471) (cherry picked from commit 3667e1e) Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
|
GH-16484 is a backport of this pull request to the 3.8 branch. |
lisroach
added a commit
that referenced
this pull request
Sep 30, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the last diff to get the child mocks detecting their type as either synchronous or asynchronous and returning AsyncMock or MagicMock (or Mock) depending on their type.
The main goal is for classes that have a mix of asynchronous and synchronous methods to auto-detect whether they should be AsyncMock or a synchronous mocks. Example:
This defies Mock's typical functionality where all child mocks follow the type of their parent mock, but after some discussion I believe the auto-detection is more important to the typical user than a consistency with current Mock style.
https://bugs.python.org/issue38163