Skip to content

bpo-38081: Fixes ntpath.realpath('NUL') #15899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zware merged 1 commit into from
Sep 11, 2019
Merged

bpo-38081: Fixes ntpath.realpath('NUL') #15899

zware merged 1 commit into from
Sep 11, 2019

Conversation

@zooba
Copy link
Member

@zooba zooba commented Sep 11, 2019 •
edited by bedevere-bot
Loading

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.8 labels Sep 11, 2019
zware
zware approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware merged commit 92521fe into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@zooba zooba deleted the bpo-38081 branch September 11, 2019 09:49
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@zooba @miss-islington
bpo-38081: Fixes ntpath.realpath('NUL') (pythonGH-15899)
5908012 
(cherry picked from commit 92521fe)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2019

GH-15903 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @zooba
bpo-38081: Fixes ntpath.realpath('NUL') (GH-15899)
57491de 
(cherry picked from commit 92521fe)

Co-authored-by: Steve Dower <steve.dower@python.org>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@zooba @websurfer5
bpo-38081: Fixes ntpath.realpath('NUL') (pythonGH-15899)
97e61e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

No one assigned

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @miss-islington @bedevere-bot @zware @the-knights-who-say-ni