Skip to content

gh-151337: Avoid possible memory leak in _tkinter.c on Windows.#151340

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
ByteFlowing1337:fix-151337
Jun 11, 2026
Merged

gh-151337: Avoid possible memory leak in _tkinter.c on Windows.#151340
serhiy-storchaka merged 1 commit into
python:mainfrom
ByteFlowing1337:fix-151337

Conversation

@ByteFlowing1337

@ByteFlowing1337 ByteFlowing1337 commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@ByteFlowing1337 ByteFlowing1337 changed the title Avoid possible memory leak in tkinter.c on Windows. gh-151337: Avoid possible memory leak in tkinter.c on Windows. Jun 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 11, 2026
Closed
@ByteFlowing1337 ByteFlowing1337 changed the title gh-151337: Avoid possible memory leak in tkinter.c on Windows. gh-151337: Avoid possible memory leak in _tkinter.c on Windows. Jun 11, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jun 11, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 11, 2026
@serhiy-storchaka serhiy-storchaka merged commit 71805db into python:main Jun 11, 2026
66 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @ByteFlowing1337 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151380 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151381 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2026
@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151379 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 11, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jun 11, 2026
@miss-islington @ByteFlowing1337
[3.13] gh-151337: Avoid possible memory leak in _tkinter.c on Windo…
e812fe9 
…ws. (GH-151340) (GH-151381)

(cherry picked from commit 71805db)

Co-authored-by: Ivy Xu <fakeshadow1337@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 11, 2026
@miss-islington @ByteFlowing1337
[3.14] gh-151337: Avoid possible memory leak in _tkinter.c on Windo…
bd314c5 
…ws. (GH-151340) (GH-151380)

(cherry picked from commit 71805db)

Co-authored-by: Ivy Xu <fakeshadow1337@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 11, 2026
@miss-islington @ByteFlowing1337
[3.15] gh-151337: Avoid possible memory leak in _tkinter.c on Windo…
e87e732 
…ws. (GH-151340) (GH-151379)

(cherry picked from commit 71805db)

Co-authored-by: Ivy Xu <fakeshadow1337@gmail.com>
@bedevere-bot

bedevere-bot commented Jun 11, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit e812fe9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/2029) and take a look at the build logs.
  4. Check if the failure is related to this commit (e812fe9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/2029

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>

@ByteFlowing1337 ByteFlowing1337 deleted the fix-151337 branch June 12, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ByteFlowing1337 @bedevere-bot @serhiy-storchaka