gh-151112: Move an assert that may fail in cfg_builder_check#151153
Merged
Conversation
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-151313 is a backport of this pull request to the 3.15 branch. |
|
GH-151314 is a backport of this pull request to the 3.14 branch. |
|
GH-151315 is a backport of this pull request to the 3.13 branch. |
StanFromIreland
added a commit
that referenced
this pull request
Jun 11, 2026
StanFromIreland
added a commit
that referenced
this pull request
Jun 11, 2026
StanFromIreland
added a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also found with the same reproducer, just setting nomemory at a different time. In
_PyCfg_FromInstructionSequenceif_PyCfgBuilder_Addopfails on the first instruction, it jumps toerrorand calls_PyCfgBuilder_Free(g). The entry block is still empty, butcfg_builder_checkassertsg_entryblock->b_iused > 0.If you want to reproduce, you'll have to play around a little with the start/stop for nomemory, but for me it's:
Debug only so skipping news.