Skip to content

gh-148605: Remove irepeat() thread test from test_bytes#150576

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
vstinner:test_bytes_irepeat
May 31, 2026
Merged

gh-148605: Remove irepeat() thread test from test_bytes#150576
kumaraditya303 merged 1 commit into
python:mainfrom
vstinner:test_bytes_irepeat

Conversation

@vstinner

@vstinner vstinner commented May 29, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The bytearray size has no bounds and can grow up to 4 GiB which is way too much memory. Since irepeat() calls were done in parallel, it was not possible to limit the bytearray size.

@vstinner
pythongh-148605: Remove irepeat() thread test from test_bytes
d7f0ca2 
The bytearray size has no bounds and can grow up to 4 GiB which is
way too much memory. Since irepeat() calls were done in parallel, it
was not possible to limit the bytearray size.
@vstinner vstinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 29, 2026
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 29, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 29, 2026
Closed
@vstinner

vstinner commented May 29, 2026

Copy link
Copy Markdown
Member Author

@colesbury @kumaraditya303: Would you mind to review this fix?

@vstinner

vstinner commented May 29, 2026

Copy link
Copy Markdown
Member Author

Tests / Windows / Build and test (Win32, switch-case) (pull_request): Failing

FAIL: test_generator_not_under_consumer_arithmetic (test.test_profiling.test_sampling_profiler.test_blocking.TestBlockingModeStackAccuracy.test_generator_not_under_consumer_arithmetic)

That's the issue gh-150429. It's unrelated to my change.

@kumaraditya303 kumaraditya303 merged commit 350e9de into python:main May 31, 2026
103 of 105 checks passed
@miss-islington-app

miss-islington-app Bot commented May 31, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented May 31, 2026

Copy link
Copy Markdown

GH-150660 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 31, 2026
@bedevere-app

bedevere-app Bot commented May 31, 2026

Copy link
Copy Markdown

GH-150661 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 31, 2026
kumaraditya303 pushed a commit that referenced this pull request Jun 1, 2026
@miss-islington @vstinner
[3.14] gh-148605: Remove irepeat() thread test from test_bytes (GH-15…
893dd4d 
…0576) (#150661)

gh-148605: Remove irepeat() thread test from test_bytes (GH-150576)
(cherry picked from commit 350e9de)

Co-authored-by: Victor Stinner <vstinner@python.org>
kumaraditya303 pushed a commit that referenced this pull request Jun 1, 2026
@miss-islington @vstinner
[3.15] gh-148605: Remove irepeat() thread test from test_bytes (GH-15…
2c1e4bb 
…0576) (#150660)

gh-148605: Remove irepeat() thread test from test_bytes (GH-150576)
(cherry picked from commit 350e9de)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner deleted the test_bytes_irepeat branch June 1, 2026 09:35
@vstinner

vstinner commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

Thanks for reviews and merging my fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @kumaraditya303