Skip to content

gh-149887: Install python3t.lib for GIL-enabled Windows install#149900

Merged
zooba merged 1 commit into
python:mainfrom
ngoldbaum:gh-149887
May 18, 2026
Merged

gh-149887: Install python3t.lib for GIL-enabled Windows install#149900
zooba merged 1 commit into
python:mainfrom
ngoldbaum:gh-149887

Conversation

@ngoldbaum

@ngoldbaum ngoldbaum commented May 15, 2026

Copy link
Copy Markdown
Contributor

@ngoldbaum

Copy link
Copy Markdown
Contributor Author

I tested this by building the installer locally on my Windows PC. There is a python3t.lib file in an install that doesn't include the free-threaded build. I can also confirm that the venv bug is fixed as well!

@ngoldbaum

Copy link
Copy Markdown
Contributor Author

@hugovk can I fire a buildbot run for this PR?

@hugovk

hugovk commented May 16, 2026

Copy link
Copy Markdown
Member

@ngoldbaum Go ahead, no need to ask. I'm always happier to see buildbot failures addressed before merge :)

Do you know how to trigger? Either apply the label for the full set, or leave a regex comment for a subset:

https://devguide.python.org/testing/buildbots/#triggering-on-pull-requests

@ngoldbaum

Copy link
Copy Markdown
Contributor Author

!buildbot .Windows.

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ngoldbaum for commit cc031de 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149900%2Fmerge

The command will test the builders whose names match following regular expression: .*Windows.*

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • ARM64 Windows PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows PGO NoGIL PR
  • AMD64 Windows PGO PR
  • AMD64 Windows10 PR
  • ARM64 Windows Non-Debug PR

@zware

zware commented May 16, 2026

Copy link
Copy Markdown
Member

Unfortunately the buildbot runs are not actually useful here; the buildbots don't build the MSI :)

@zooba

zooba commented May 18, 2026

Copy link
Copy Markdown
Member

I think the only weirdness we're likely to see here is around people who add and remove the free-threaded binaries and discover that this file has (probably) been deleted, in which case they can do a repair to get it back. Since it should be effectively identical to the same file from the free-threaded build, it shouldn't matter if both are installed.

@zooba zooba merged commit bd6bf91 into python:main May 18, 2026
71 checks passed
@zooba

zooba commented May 18, 2026

Copy link
Copy Markdown
Member

Thanks @ngoldbaum for the PR!

@zooba zooba added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 18, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @ngoldbaum for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented May 18, 2026

Copy link
Copy Markdown

GH-149987 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 18, 2026
zooba pushed a commit that referenced this pull request May 18, 2026
GH-149900)

gh-149887: Install python3t.lib for GIL-enabled Windows install (GH-149900)
(cherry picked from commit bd6bf91)

Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants