Skip to content

gh-149056: properly pass array_hook to json.loads#149057

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-properly-pass-array_hook-to-json-loads
May 29, 2026
Merged

gh-149056: properly pass array_hook to json.loads#149057
serhiy-storchaka merged 2 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-properly-pass-array_hook-to-json-loads

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Apr 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

What is this PR?

This PR fixes the issue reported in #149056 where the array_hook parameter isn't properly being forwarded to json.loads by json.load.

@bedevere-app bedevere-app Bot mentioned this pull request Apr 27, 2026
Closed
@read-the-docs-community

read-the-docs-community Bot commented Apr 29, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32463964 | 📁 Comparing d77afb2 against main (a386a52)

  🔍 Preview build  

3 files changed
± download.html
± library/socket.html
± whatsnew/changelog.html

@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 29, 2026 09:03
serhiy-storchaka
serhiy-storchaka approved these changes May 29, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 29, 2026
@serhiy-storchaka serhiy-storchaka merged commit f87d960 into python:main May 29, 2026
62 checks passed
@miss-islington-app

miss-islington-app Bot commented May 29, 2026

Copy link
Copy Markdown

Thanks @KowalskiThomas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented May 29, 2026

Copy link
Copy Markdown

GH-150591 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 29, 2026
serhiy-storchaka pushed a commit that referenced this pull request May 29, 2026
@miss-islington @KowalskiThomas
[3.15] gh-149056: Properly pass array_hook in json.load() to json.loa…
863c7e0 
…ds() (GH-149057) (GH-150591)

(cherry picked from commit f87d960)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KowalskiThomas @serhiy-storchaka