Skip to content

bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last modification #14320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Jun 23, 2019
Merged

bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last modification #14320

pablogsal merged 1 commit into from
Jun 23, 2019

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 23, 2019 •
edited by bedevere-bot
Loading

@pablogsal pablogsal self-assigned this Jun 23, 2019
gvanrossum
gvanrossum approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Serhiy says so. :-)

@pablogsal pablogsal merged commit b3ca797 into python:master Jun 23, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@pablogsal pablogsal deleted the bpo35224-3 branch June 23, 2019 16:00
@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2019
@pablogsal @miss-islington
bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last mo…
8134c1f 
…dification (pythonGH-14320)

(cherry picked from commit b3ca797)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 23, 2019

GH-14321 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 23, 2019
@miss-islington @pablogsal
bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last mo…
175b2e9 
…dification (GH-14320)

(cherry picked from commit b3ca797)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last mo…
504631b 
…dification (pythonGH-14320)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-35224: Bump the pyc magic number by 1 instead of by 10 in last mo…
a01a26d 
…dification (pythonGH-14320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni