bpo-37212: Preserve keyword argument order in unittest.mock.call and error messages #14310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocj89
approved these changes
Jun 22, 2019
ammaraskar
approved these changes
Sep 9, 2019
Member
ammaraskar
left a comment
There was a problem hiding this comment.
LGTM, preserving the call order is far more intuitive.
And for reference this is just a visual change useful for users introspecting test failures and such,
>>> m = Mock()
>>> m(b=1, a=2)
>>> m.assert_called_with(a=2, b=1)works and will continue to work.
Contributor
|
Thanks @tirkarthi for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
…error messages (pythonGH-14310) (cherry picked from commit 9d60706) Co-authored-by: Xtreak <tir.karthi@gmail.com>
|
GH-15755 is a backport of this pull request to the 3.8 branch. |
Member
|
Thanks for the patch, @tirkarthi, and for the reviews @dhilst and @ammaraskar! Due to the (admittedly very slim) chance that this could break things for someone who shouldn't be relying on repr orders anyway, I won't backport this further than 3.8. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.6 the order of keyword arguments is preserved. Change
mock.callrepr and error messages to print the original order instead of sorting it.https://bugs.python.org/issue37212