Skip to content

gh-143082: Fix readline backend check and stdin isatty condition in cmd and pdb modules#143083

Merged
gaogaotiantian merged 5 commits into
python:mainfrom
zelosleone:fixstdinandcmd
Jan 5, 2026
Merged

gh-143082: Fix readline backend check and stdin isatty condition in cmd and pdb modules#143083
gaogaotiantian merged 5 commits into
python:mainfrom
zelosleone:fixstdinandcmd

Conversation

@zelosleone

@zelosleone zelosleone commented Dec 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated the readline backend check to use getattr for compatibility.
  • Modified the stdin condition in pdb to ensure isatty is checked correctly, preventing potential issues with non-tty inputs.

Related Issues:

@bedevere-app

bedevere-app Bot commented Dec 22, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot

python-cla-bot Bot commented Dec 22, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2025
Closed
@zelosleone zelosleone mentioned this pull request Dec 22, 2025
Closed
@bedevere-app

bedevere-app Bot commented Dec 22, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Dec 25, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Zac-HD Zac-HD mentioned this pull request Jan 3, 2026
Closed
@gaogaotiantian gaogaotiantian merged commit 68fcb95 into python:main Jan 5, 2026
50 checks passed
@gaogaotiantian

gaogaotiantian commented Jan 5, 2026

Copy link
Copy Markdown
Member

Thank you for the contribution!

@zelosleone zelosleone deleted the fixstdinandcmd branch January 5, 2026 05:09
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@zelosleone @thunder-coding
pythongh-143082: Make readline work when sys.stdin is explicitly pass…
5bba52e 
…ed to pdb (python#143083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zelosleone @gaogaotiantian