gh-142776: Ensure fp file descriptor is closed on all code paths in import.c#142777
Merged
brettcannon merged 2 commits intopython:mainfrom Dec 19, 2025
Merged
gh-142776: Ensure fp file descriptor is closed on all code paths in import.c#142777brettcannon merged 2 commits intopython:mainfrom
brettcannon merged 2 commits intopython:mainfrom
Conversation
brettcannon
requested changes
Dec 16, 2025
Member
brettcannon
left a comment
There was a problem hiding this comment.
There's a potential uninitialized use of fp now.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Author
Oops. Refactored a bit, I believe it's better now. |
kumaraditya303
approved these changes
Dec 17, 2025
brettcannon
requested changes
Dec 17, 2025
Member
brettcannon
left a comment
There was a problem hiding this comment.
Would you mind adding a news entry?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…de paths in import.c Address review comments and add a NEWS entry
brettcannon
approved these changes
Dec 18, 2025
Member
|
@stratakis is this ready to go or did you have more that you wanted to do (you didn't leave the magic comment to signal you were done, although it appears you addressed everything). |
Contributor
Author
|
Yeah, everything done :) Noting for the squash that I got a fixup commit there, you might not want to add the title of it to the commit message. |
|
Thanks @stratakis for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @stratakis and @brettcannon, I could not cleanly backport this to |
|
Sorry, @stratakis and @brettcannon, I could not cleanly backport this to |
Member
|
@stratakis thanks for the PR! Any chance you're up for backporting? |
Contributor
Author
Sure, I'll work on the backports |
|
stratakis
added a commit
to stratakis/cpython
that referenced
this pull request
Dec 19, 2025
…s in import.c (pythonGH-142777) (cherry picked from commit 6a4f103)
|
GH-142988 is a backport of this pull request to the 3.14 branch. |
|
GH-142989 is a backport of this pull request to the 3.13 branch. |
stratakis
added a commit
to stratakis/cpython
that referenced
this pull request
Dec 19, 2025
…s in import.c (pythonGH-142777) (cherry picked from commit 6a4f103)
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 20, 2025
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 20, 2025
cocolato
pushed a commit
to cocolato/cpython
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.