gh-140766: add enum.show_flag_values and enum.bin to enum.__all__#140765
gh-140766: add enum.show_flag_values and enum.bin to enum.__all__#140765ethanfurman merged 4 commits intopython:mainfrom
enum.show_flag_values and enum.bin to enum.__all__#140765Conversation
enum.show_flag_values to enum.__all__enum.show_flag_values to enum.__all__
|
It appears that Line 5327 in c74793c https://docs.python.org/3/library/enum.html#enum.show_flag_values |
|
Hmm. That seems odd to me, but I'll defer to @ethanfurman here as the enum maintainer :-) |
|
Let's go ahead and put both in |
ethanfurman
left a comment
There was a problem hiding this comment.
Add both bin and show_flag_values to __all__.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
|
|
enum.show_flag_values to enum.__all__enum.show_flag_values and enum.bin to enum.__all__
Misc/NEWS.d/next/Library/2025-10-29-16-53-00.gh-issue-140766.CNagKF.rst
Outdated
Show resolved
Hide resolved
…NagKF.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ethanfurman
left a comment
There was a problem hiding this comment.
Looks good. @guoci, I'm happy to commit as-is, or you can add bin to the docs -- whatever you are comfortable with.
|
@ethanfurman Thanks, I will add in the docs sometime later, you can commit now. |
…ll__` (pythonGH-140765) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
Fix as suggested in:
python/typeshed#14938 (comment)
enum.show_flag_valuesinenum.__all__#140766