Skip to content

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jun 11, 2019

Lumping these together because they both come from the static type checking world.

https://bugs.python.org/issue35766

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I looked for "3.8" in https://docs.python.org/dev/library/ast.html and https://docs.python.org/dev/library/typing.html and it seems like all changes are documented.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gvanrossum gvanrossum merged commit 9b33ce4 into python:master Jun 11, 2019
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@gvanrossum gvanrossum deleted the whats-new-ast-typing branch June 11, 2019 20:42
@bedevere-bot
Copy link

GH-13987 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2019
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington added a commit that referenced this pull request Jun 11, 2019
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants