Skip to content

Do not use explicit inheritance from object in the documentation.#13936

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:docs-no-explicit-object
Jun 10, 2019
Merged

Do not use explicit inheritance from object in the documentation.#13936
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:docs-no-explicit-object

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

No description provided.

@serhiy-storchaka serhiy-storchaka force-pushed the docs-no-explicit-object branch from 0db3116 to db99254 Compare June 10, 2019 05:12
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit e042a45 into python:master Jun 10, 2019
@serhiy-storchaka serhiy-storchaka deleted the docs-no-explicit-object branch June 10, 2019 10:35
@rhettinger
Copy link
Copy Markdown
Contributor

FWIW, the explicit inheritance in the descriptor how-to was intentional.

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

It was intentional in Python 2. But in Python 3 it just confuses readers and stays bad practice.

I left the explicit inheritance in the case when it is used to explain the difference with the implicit inheritance (actually no difference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants