Skip to content

bpo-28556: Routine updates to typing#1366

Merged
Mariatta merged 5 commits intopython:masterfrom
ilevkivskyi:update-typing-22
May 2, 2017
Merged

bpo-28556: Routine updates to typing#1366
Mariatta merged 5 commits intopython:masterfrom
ilevkivskyi:update-typing-22

Conversation

@ilevkivskyi
Copy link
Member

typing module was last updated 2 months ago. Here are few more updates:

  • Add NoReturn type
  • Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard)
  • Minor bug-fixes

This needs to be backported to 3.5 and 3.6

Attn: @gvanrossum

@mention-bot
Copy link

@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zware, @serhiy-storchaka and @rhettinger to be potential reviewers.

@Mariatta
Copy link
Member

Mariatta commented May 2, 2017

Maybe update Misc/NEWS too?

@ilevkivskyi
Copy link
Member Author

Maybe update Misc/NEWS too?

Thank you @Mariatta, good point! Fixed this.

@Mariatta
Copy link
Member

Mariatta commented May 2, 2017

And of course there is a conflict now :(
@ilevkivskyi Do you mind resolving it first? Otherwise I think it looks good.

@ilevkivskyi
Copy link
Member Author

@Mariatta

Do you mind resolving it first?

Resolved.

@Mariatta
Copy link
Member

Mariatta commented May 2, 2017

Thanks :) I'll merge after the build is finished.

@Mariatta Mariatta merged commit f06e021 into python:master May 2, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request May 3, 2017
- Add NoReturn type
- Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard)
- Minor bug-fixes
(cherry picked from commit f06e021)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request May 3, 2017
- Add NoReturn type
- Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard)
- Minor bug-fixes
(cherry picked from commit f06e021)
Mariatta added a commit that referenced this pull request May 3, 2017
- Add NoReturn type
- Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard)
- Minor bug-fixes
(cherry picked from commit f06e021)
Mariatta added a commit that referenced this pull request May 3, 2017
- Add NoReturn type
- Use WrapperDescriptorType (original PR by Jim Fasarakis-Hilliard)
- Minor bug-fixes
(cherry picked from commit f06e021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants