gh-136492: Add `FrameLocalsProxyType` to `types` by ZeroIntensity · Pull Request #136546 · python/cpython

ZeroIntensity · 2025-07-11T14:27:42Z

Expose PEP-667's FrameLocalsProxy type as FrameLocalsProxyType in the types module.

Issue: FrameLocalsProxy (PEP 667) is not registered as a subclass of abc.Mapping #136492

📚 Documentation preview 📚: https://cpython-previews--136546.org.readthedocs.build/en/136546/library/types.html#types.FrameLocalsProxyType

Doc/whatsnew/3.15.rst

Lib/test/test_types.py

ZeroIntensity · 2025-07-11T15:14:01Z

Ugh, those test failures look like an existing bug on FrameLocalsProxy.

picnixz · 2025-07-11T17:00:18Z

@python/organization-owners Could you block blockchainGuru1018 for spam & misguided reviews? TiA.

Doc/library/types.rst

gaogaotiantian · 2025-07-11T19:16:27Z

Ugh, those test failures look like an existing bug on FrameLocalsProxy.

Could you be more specific? Maybe raise an issue for that so I can fix it later?

ZeroIntensity · 2025-07-11T19:33:12Z

Could you be more specific? Maybe raise an issue for that so I can fix it later?

There were a few things I had to skip in test_inspect. I think they're bugs, but I haven't investigated the test enough to be sure.

gaogaotiantian · 2025-07-11T19:51:27Z

Okay now we need some typing expert to review this. @JelleZijlstra maybe?

ZeroIntensity · 2025-07-12T12:59:33Z

I'd also appreciate it if @AA-Turner could take a look; he's done some recent work with types and _types.

JelleZijlstra · 2025-07-12T16:34:50Z

You don't really need a static typing expert for the types module; it predates static typing and is useful even without static typing. The PR seems pretty straightforward to me.

Doc/whatsnew/3.15.rst

Lib/test/test_inspect/test_inspect.py

Lib/types.py

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

…nsity/cpython into frameslocalsproxy-types

Misc/NEWS.d/next/Library/2025-07-11-10-23-44.gh-issue-136492.BVi5h0.rst

Doc/library/types.rst

AA-Turner · 2025-07-15T08:22:31Z

Lib/test/test_types.py

            'MethodDescriptorType', 'MethodType', 'MethodWrapperType',
            'ModuleType', 'NoneType', 'NotImplementedType', 'SimpleNamespace',
            'TracebackType', 'UnionType', 'WrapperDescriptorType',
+            'FrameLocalsProxyType'


Please keep the list sorted (GH doesn't let me add a suggestion)

I had that originally but @picnixz had reservations about it.

I think it's better to keep the list sorted rather than attempt to minimise 3-4 lines of diff here.

My suggestion was to keep it sorted but by just adding the export on its own line.

Sorry, missed this. I've updated it now; does that look better?

Lib/test/test_types.py

Lib/types.py

Objects/frameobject.c

Doc/whatsnew/3.15.rst

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

This reverts commit 58e8577.

This reverts commit 22c2bbe.

…nsity/cpython into frameslocalsproxy-types

This reverts commit fee5256.

Should I test before I push my changes? Yes. Will I ever do it? No.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Lib/test/test_inspect/test_inspect.py

AA-Turner

Thanks!

A

Objects/frameobject.c

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

ZeroIntensity · 2025-07-20T17:33:43Z

Any final objections before I merge this?

AA-Turner · 2025-07-20T18:10:02Z

All good with me.

A

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

ZeroIntensity added 8 commits July 11, 2025 10:12

Expose FrameLocalsProxy in types and _types

78b842c

Add a test case.

e2ddcbe

Add a documentation entry.

22e056d

Use the 'type' suffix.

b8fd733

Add a whatsnew entry.

abbe1d3

Add blurb.

753c9bc

Fix the tests.

b087d9b

Sort the name alphabetically.

1971a14

ZeroIntensity requested a review from gaogaotiantian July 11, 2025 14:27

bedevere-app bot added the awaiting core review label Jul 11, 2025

bedevere-app bot mentioned this pull request Jul 11, 2025

FrameLocalsProxy (PEP 667) is not registered as a subclass of abc.Mapping #136492

Closed

Sort alphabetically in _types.

fdeb2d0

picnixz reviewed Jul 11, 2025

View reviewed changes

Doc/whatsnew/3.15.rst Outdated Show resolved Hide resolved

Lib/test/test_types.py Outdated Show resolved Hide resolved

ZeroIntensity added 3 commits July 11, 2025 11:08

Move whatsnew section.

c8600b9

Somewhat fix the tests.

70cc4db

Reduce the diff.

fee5256

Use a workaround for the tests.

a110148

This comment was marked as spam.

Sign in to view

gaogaotiantian reviewed Jul 11, 2025

View reviewed changes

Doc/library/types.rst Outdated Show resolved Hide resolved

gaogaotiantian reviewed Jul 11, 2025

View reviewed changes

Doc/library/types.rst Outdated Show resolved Hide resolved

Move PEP note and remove locals() reference.

929f81e

JelleZijlstra reviewed Jul 12, 2025

View reviewed changes

Doc/whatsnew/3.15.rst Outdated Show resolved Hide resolved

Lib/test/test_inspect/test_inspect.py Outdated Show resolved Hide resolved

Lib/test/test_inspect/test_inspect.py Outdated Show resolved Hide resolved

Lib/types.py Outdated Show resolved Hide resolved

Update Doc/whatsnew/3.15.rst

fb710eb

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Add a signature for FrameLocalsProxy()

5923263

ZeroIntensity requested a review from markshannon as a code owner July 12, 2025 20:58

ZeroIntensity added 4 commits July 15, 2025 03:54

Change the tp_name to types.FrameLocalsProxyType.

22c2bbe

Merge branch 'main' into frameslocalsproxy-types

9bca253

Fix type name in test_frame.

58e8577

Merge branch 'frameslocalsproxy-types' of https://github.com/zerointe…

bdabeaf

…nsity/cpython into frameslocalsproxy-types

AA-Turner reviewed Jul 15, 2025

View reviewed changes

Apply suggestions from code review

7a649c2

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner changed the title ~~gh-136492: Add FrameLocalsProxy to types~~ gh-136492: Add FrameLocalsProxyType to types Jul 15, 2025

ZeroIntensity and others added 7 commits July 15, 2025 04:40

Revert "Fix type name in test_frame."

e0f674d

This reverts commit 58e8577.

Revert "Change the tp_name to types.FrameLocalsProxyType."

faa4cf4

This reverts commit 22c2bbe.

Merge branch 'frameslocalsproxy-types' of https://github.com/zerointe…

ca05198

…nsity/cpython into frameslocalsproxy-types

Revert "Reduce the diff."

0463c30

This reverts commit fee5256.

Fix tests that were broken by the tp_name revert.

59daace

Should I test before I push my changes? Yes. Will I ever do it? No.

Unify how FrameType and FrameLocalsProxyType are created.

349374d

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Keep it sorted but with a smaller diff.

287c993

AA-Turner reviewed Jul 20, 2025

View reviewed changes

Lib/test/test_inspect/test_inspect.py Outdated Show resolved Hide resolved

trailing comma

047f59e

AA-Turner approved these changes Jul 20, 2025

View reviewed changes

Objects/frameobject.c Outdated Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting core review labels Jul 20, 2025

Update frameobject.c

63e263e

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner added the sprint label Jul 20, 2025

ZeroIntensity merged commit 8f59fbb into python:main Jul 20, 2025
43 checks passed

bedevere-app bot removed the awaiting merge label Jul 20, 2025

ZeroIntensity deleted the frameslocalsproxy-types branch July 20, 2025 18:49

Uh oh!

Conversation

ZeroIntensity commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity commented Jul 11, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

picnixz commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

gaogaotiantian commented Jul 11, 2025

Uh oh!

ZeroIntensity commented Jul 11, 2025

Uh oh!

gaogaotiantian commented Jul 11, 2025

Uh oh!

ZeroIntensity commented Jul 12, 2025

Uh oh!

JelleZijlstra commented Jul 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

AA-Turner Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ZeroIntensity commented Jul 20, 2025

Uh oh!

AA-Turner commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZeroIntensity commented Jul 11, 2025 •

edited

Loading