Skip to content

gh-136156: Skip test_tempfile.test_link_tmpfile() on Android#136430

Merged
freakboy3742 merged 3 commits into
python:mainfrom
vstinner:test_tempfile_android
Jul 9, 2025
Merged

gh-136156: Skip test_tempfile.test_link_tmpfile() on Android#136430
freakboy3742 merged 3 commits into
python:mainfrom
vstinner:test_tempfile_android

Conversation

@vstinner

@vstinner vstinner commented Jul 8, 2025

Copy link
Copy Markdown
Member

@vstinner

vstinner commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

@vstinner

vstinner commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

PR written to fix this regression: #136281 (comment)

Comment thread Lib/test/test_tempfile.py Outdated
@mhsmith

mhsmith commented Jul 8, 2025

Copy link
Copy Markdown
Member

test.support.os_helper.skip_unless_hardlink would be a simpler way of doing this, and would also avoid hiding failures caused by PermissionError on platforms where it's not expected.

@vstinner

vstinner commented Jul 9, 2025

Copy link
Copy Markdown
Member Author

test.support.os_helper.skip_unless_hardlink would be a simpler way of doing this, and would also avoid hiding failures caused by PermissionError on platforms where it's not expected.

Good idea. I updated my PR to use @skip_unless_hardlink.

@mhsmith

mhsmith commented Jul 9, 2025

Copy link
Copy Markdown
Member

!buildbot android

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c21182d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136430%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@mhsmith mhsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freakboy3742: Please merge if someone else hasn't already.

@freakboy3742 freakboy3742 merged commit 92b33c9 into python:main Jul 9, 2025
41 checks passed
@vstinner vstinner deleted the test_tempfile_android branch July 9, 2025 23:04
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…ython#136430)

Adds a test skip on platforms where hard links are not available (which includes Android).
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…ython#136430)

Adds a test skip on platforms where hard links are not available (which includes Android).
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
…ython#136430)

Adds a test skip on platforms where hard links are not available (which includes Android).
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…ython#136430)

Adds a test skip on platforms where hard links are not available (which includes Android).
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…ython#136430)

Adds a test skip on platforms where hard links are not available (which includes Android).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants