Skip to content

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and **#136395

Merged
Eclips4 merged 5 commits into
python:mainfrom
Tapeline:fix-gh-136327
Oct 24, 2025
Merged

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and **#136395
Eclips4 merged 5 commits into
python:mainfrom
Tapeline:fix-gh-136327

Conversation

@Tapeline

@Tapeline Tapeline commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Solved removing function name from error message entirely

@python-cla-bot

python-cla-bot Bot commented Jul 7, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@Tapeline Tapeline changed the title gh-12345: Fix inconsistent TypeError messages regarding invalid values after * and ** gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** Jul 7, 2025
Comment thread Python/ceval.c
Comment thread Python/ceval.c
Comment thread Python/ceval.c

@efimov-mikhail efimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it :)

Comment thread Lib/test/test_extcall.py Outdated

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tapeline

Copy link
Copy Markdown
Contributor Author

@markshannon, could you please review this?

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-07-08-00-41-46.gh-issue-136327.7AiTb_.rst Outdated
@Tapeline

Tapeline commented Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

Hi, @hugovk, could you please take a look at the error message wording change, since you are an RM. Do you think it looks better now? :)

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ashm-dev ashm-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-07-08-00-41-46.gh-issue-136327.7AiTb_.rst Outdated
@Eclips4 Eclips4 enabled auto-merge (squash) October 24, 2025 18:47

@sergey-miryanov sergey-miryanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Eclips4 Eclips4 merged commit 4f8e7b5 into python:main Oct 24, 2025
51 checks passed
eliegoudout added a commit to eliegoudout/paramclasses that referenced this pull request Nov 21, 2025
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
eliegoudout added a commit to eliegoudout/paramclasses that referenced this pull request Nov 21, 2025
* pkg: python 3.15.0a1 compat + free-threaded versions

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

* fix: 3.15.0a2 compatibility (python/cpython/pull/136395) [skip ci]

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

* dev: update ci versions

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

* fix: revert bad factor

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

---------

Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants