gh-136203: Improve TypeError msg when comparing two MappingProxyTypes#136204
Merged
Conversation
vstinner
approved these changes
Jul 2, 2025
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. I just have a minor suggestion.
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
Author
|
We generally don't backport error message changes. If needed - please, let me know :) |
Member
Author
|
Thanks everyone! |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…roxyType`s (python#136204) Co-authored-by: Victor Stinner <vstinner@python.org>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…roxyType`s (python#136204) Co-authored-by: Victor Stinner <vstinner@python.org>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
…roxyType`s (python#136204) Co-authored-by: Victor Stinner <vstinner@python.org>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…roxyType`s (python#136204) Co-authored-by: Victor Stinner <vstinner@python.org>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…roxyType`s (python#136204) Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @efimov-mikhail
mappingproxyobjects #136203