Skip to content

gh-136193: Improve TypeError msg when comparing two SimpleNamespaces#136195

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-136193
Jul 2, 2025
Merged

gh-136193: Improve TypeError msg when comparing two SimpleNamespaces#136195
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-136193

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 2, 2025

Copy link
Copy Markdown
Member

Comment thread Lib/test/test_types.py
Comment thread Lib/test/test_types.py Outdated

@efimov-mikhail efimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm on renaming test to test_richcompare_unsupported.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@sobolevn

sobolevn commented Jul 2, 2025

Copy link
Copy Markdown
Member Author

We usually don't backport error message changes, so I won't backport this as well.
In case anyone will need a backport - I am ok with creating one, when there's a clear use-case for it.

@sobolevn sobolevn merged commit ab7196a into python:main Jul 2, 2025
44 checks passed
@gold24kETH

Copy link
Copy Markdown

yes i waiting from this

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants