Skip to content

gh-135069: Fix exception message in encodings.idna module#135071

Merged
kumaraditya303 merged 4 commits intopython:mainfrom
danielhollas:encodings-fix-fstring
Jul 3, 2025
Merged

gh-135069: Fix exception message in encodings.idna module#135071
kumaraditya303 merged 4 commits intopython:mainfrom
danielhollas:encodings-fix-fstring

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

@danielhollas danielhollas commented Jun 3, 2025 •
edited by bedevere-app bot
Loading

Fixes #135069.

Requires backport to 3.13 and 3.14 branches.

@danielhollas
Fix exception message in encodings.idna module
fe37cdc 
Fix the 'Unsupported error handling' error message
in the encodings.idna.IncrementalDecoder class.
@danielhollas
Add blurb
78be462
@bedevere-app bedevere-app bot mentioned this pull request Jun 3, 2025
Closed
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 3, 2025
@danielhollas
Copy link
Copy Markdown
Contributor Author

danielhollas commented Jun 3, 2025 •
edited
Loading

The docs build fails with

cpython/cpython/Doc/build/NEWS:91: WARNING: py:meth reference target not found: encodings.idna.IncrementalDecoder.decode [ref.meth]

The decode method comes from a parent class I believe. Should a link to the private _buffer_decode method instead?

@tomasr8
Copy link
Copy Markdown
Member

tomasr8 commented Jun 3, 2025

Should a link to the private _buffer_decode method instead?

You could also just link to IncrementalDecoder

@danielhollas
Copy link
Copy Markdown
Contributor Author

danielhollas commented Jun 3, 2025 •
edited
Loading

You could also just link to IncrementalDecoder

Thanks, makes sense to me. I tried to change it but still got an error:

cpython/Doc/build/NEWS:91: WARNING: py:class reference target not found: encodings.idna.IncrementalDecoder [ref.class]

No matter how long I stare at it the new blurb looks correct to me? Apologies if that is something obvious, I don't have much experience with rst.

EDIT: The windows build failure looks like a transient http error?

@tomasr8
Copy link
Copy Markdown
Member

tomasr8 commented Jun 4, 2025

Maybe we can suppress the reference with !? Something like

 `:class:`!encodings.idna.IncrementalDecoder

@danielhollas
Copy link
Copy Markdown
Contributor Author

danielhollas commented Jun 4, 2025

Maybe we can suppress the reference with !?

That worked, thanks!

tomasr8
tomasr8 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The news entry could be even shorter (and with less detail) but I think this is also fine 🙂

@danielhollas
Copy link
Copy Markdown
Contributor Author

danielhollas commented Jun 23, 2025

@tomasr8 @ZeroIntensity congratulations to both on becoming core developers! 👏

I guess this PR could be merged if you re-apply your review now? 😊

ZeroIntensity
ZeroIntensity approved these changes Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to hit the green button @tomasr8?

@tomasr8
Copy link
Copy Markdown
Member

tomasr8 commented Jun 23, 2025

Feel free to press it @ZeroIntensity! 🙂 I'm a bit busy today 😅

@kumaraditya303 kumaraditya303 merged commit 8dc3383 into python:main Jul 3, 2025
47 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Jul 3, 2025

Thanks @danielhollas for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2025
@danielhollas @miss-islington
pythongh-135069: Fix exception message in encodings.idna module (pyth…
7939530 
…onGH-135071)

(cherry picked from commit 8dc3383)

Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2025
@danielhollas @miss-islington
pythongh-135069: Fix exception message in encodings.idna module (pyth…
08ae3f8 
…onGH-135071)

(cherry picked from commit 8dc3383)

Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Jul 3, 2025

GH-136235 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Jul 3, 2025

GH-136236 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 3, 2025
@miss-islington @danielhollas
[3.14] gh-135069: Fix exception message in encodings.idna module (GH-…
4bc9c01 
…135071) (#136235)

gh-135069: Fix exception message in encodings.idna module (GH-135071)
(cherry picked from commit 8dc3383)

Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
kumaraditya303 pushed a commit that referenced this pull request Jul 3, 2025
@miss-islington @danielhollas
[3.13] gh-135069: Fix exception message in encodings.idna module (GH-…
fc77192 
…135071) (#136236)

gh-135069: Fix exception message in encodings.idna module (GH-135071)
(cherry picked from commit 8dc3383)

Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
@danielhollas danielhollas deleted the encodings-fix-fstring branch July 3, 2025 10:44
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@danielhollas @AndPuQing
pythongh-135069: Fix exception message in encodings.idna module (pyt…
95d062f 
…hon#135071)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@danielhollas @Pranjal095
pythongh-135069: Fix exception message in encodings.idna module (pyt…
d2e7701 
…hon#135071)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@danielhollas @picnixz
pythongh-135069: Fix exception message in encodings.idna module (pyt…
1c514a3 
…hon#135071)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@danielhollas @taegyunkim
pythongh-135069: Fix exception message in encodings.idna module (pyt…
58ec9cb 
…hon#135071)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@danielhollas @Agent-Hellboy
pythongh-135069: Fix exception message in encodings.idna module (pyt…
0435e74 
…hon#135071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

encodings.idna: Unexpanded f-string in "Unsupported error handling" exception

4 participants

@danielhollas @tomasr8 @ZeroIntensity @kumaraditya303