Skip to content

gh-134486: Fix missing alloca symbol in _ctypes on NetBSD.#134487

Merged
vstinner merged 1 commit into
python:mainfrom
collinfunk:fix-alloca-definition
May 23, 2025
Merged

gh-134486: Fix missing alloca symbol in _ctypes on NetBSD.#134487
vstinner merged 1 commit into
python:mainfrom
collinfunk:fix-alloca-definition

Conversation

@collinfunk

@collinfunk collinfunk commented May 22, 2025

Copy link
Copy Markdown
Contributor

Previously the module would fail to load because the alloca symbol was undefined. Now we check for GCC/Clang builtins for systems who do not define alloca in headers.

@AA-Turner

Copy link
Copy Markdown
Member

!buildbot BSD

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 46b0d9d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134487%2Fmerge

The command will test the builders whose names match following regular expression: BSD

The builders matched are:

  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, buildbot failure looks unrelated.

Comment thread Misc/NEWS.d/next/Build/2025-05-21-22-13-30.gh-issue-134486.yvdL6f.rst Outdated
Comment thread Modules/_ctypes/ctypes.h Outdated
Comment thread Modules/_ctypes/ctypes.h Outdated
Comment thread Misc/NEWS.d/next/Build/2025-05-21-22-13-30.gh-issue-134486.yvdL6f.rst Outdated
Previously the module would fail to load because the ``alloca`` symbol
was undefined. Now we check for GCC/Clang builtins for systems who do
not define ``alloca`` in headers.
@collinfunk collinfunk requested a review from vstinner May 23, 2025 01:44

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@furkanonder furkanonder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The issue occurs on NetBSD 10.0 (ARM architecture). As a check, I tested the changes in the PR on NetBSD 10.0 (amd64) and got a successful build.

@vstinner vstinner merged commit b8f5526 into python:main May 23, 2025
43 checks passed
@vstinner

Copy link
Copy Markdown
Member

Merged, thank you.

@collinfunk collinfunk deleted the fix-alloca-definition branch May 23, 2025 18:01
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…thon#134487)

Previously the module would fail to load because the `alloca()` symbol
was undefined. Now we check for GCC/Clang builtins for systems who do
not define `alloca()` in headers.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…thon#134487)

Previously the module would fail to load because the `alloca()` symbol
was undefined. Now we check for GCC/Clang builtins for systems who do
not define `alloca()` in headers.
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
…thon#134487)

Previously the module would fail to load because the `alloca()` symbol
was undefined. Now we check for GCC/Clang builtins for systems who do
not define `alloca()` in headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants