Skip to content

bpo-29883: Asyncio proactor udp #13440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 49 commits into from
May 28, 2019
Merged

bpo-29883: Asyncio proactor udp #13440

miss-islington merged 49 commits into from
May 28, 2019

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented May 20, 2019 •
edited by bedevere-bot
Loading

ameily and others added 21 commits May 2, 2019 18:17
@ameily
bpo-29883: Add UDP to Windows Proactor Event Loop
e9084a1
@ameily
fix AppVeyor issues
1c72ea5
@ameily
fixed UDP proactor tests
668d6d7
@ameily
add missing cast to PyCFunction
05a704c
@ameily
implement extra data for proactor UDP transport
685ed0f
@ameily
enable UDP proactor unit tests on Windows
038739e
@ameily
fix bad rebase of datagram proactor tests
ae14118
@ameily
add news item for bpo29883
93ce3f8
@ameily
fix bad rebase with missing finish_recv() in recv_into()
781e2ef
@ameily
change WSAConnect to a module method
8761fcd
@ameily
PEP 7 fixes and address PR feedback
5e3d4d3
@ameily
fix build error
d25833d
@ameily
simplify calls to super()
16d2ce7
@ameily
address PR feedback
da40f28
@asvetlov @ameily
Update asyncio-eventloop.rst
2962f5c
@ameily
address feedback from PR
ce73a32
@ameily
fix bad rebase
4211be9
@ameily
address PR feedback
504ae83
@ameily
fix memory leak
58e9f8d
@ameily
fix memory leak when receiving on UDP endpoint
0c935b0
@asvetlov
Merge branch 'fix-issue-29883' of git://github.com/ameily/cpython int…
7cd4165 
…o asyncio-proactor-udp
@asvetlov asvetlov marked this pull request as ready for review May 25, 2019 12:52
@asvetlov asvetlov requested a review from 1st1 as a code owner May 25, 2019 12:52
@asvetlov
Copy link
Contributor Author

asvetlov commented May 25, 2019

@vstinner would you review this PR? If you have no time please let me know anyway.

It is a continuation of #1067 with the following differences:

  1. Support scope_id and flowinfo for IPv6 addresses
  2. Fix tp_traverse to process data structures for TYPE_WRITE_TO and TYPE_READ_FROM modes
  3. Increase buffer size for readfrom from 4KiB to 256Kib (256 is used by selector-based event loops)
  4. Support flow-control for data sending, now proactor implementation has the same functionality as selector-based one.
  5. Convert mutable bytearray and memoryview on writing to immutable bytes. The selector-based implementation does the same already.
  6. Add more tests.

I believe that the Pull Request is written well and ready for merging.

@asvetlov asvetlov requested a review from vstinner May 25, 2019 13:43
tirkarthi
tirkarthi reviewed May 26, 2019
View reviewed changes
@asvetlov @tirkarthi
Update Lib/asyncio/proactor_events.py
2b8e51e 
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
1st1
1st1 reviewed May 28, 2019
View reviewed changes
1st1
1st1 reviewed May 28, 2019
View reviewed changes
Modules/overlapped.c
return NULL;
}

Py_BEGIN_ALLOW_THREADS
Copy link
Member

@1st1 1st1 May 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If WSAConnect returns immediately, do we need to release GIL?

Copy link
Contributor Author

@asvetlov asvetlov May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it is a syscall.
We have the practice to release GIL on socket.bind() for example

1st1
1st1 approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge with caution as I'm not a Windows expert.

@miss-islington miss-islington merged commit bafd4b5 into python:master May 28, 2019
@asvetlov asvetlov mentioned this pull request May 28, 2019
Closed
@asvetlov
Copy link
Contributor Author

asvetlov commented May 28, 2019

Thank you very much @ameily
You did the most part of work!

@asvetlov asvetlov deleted the asyncio-proactor-udp branch May 28, 2019 09:54
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asvetlov @DinoV
bpo-29883: Asyncio proactor udp (pythonGH-13440)
8e8629a 
Follow-up for python#1067


https://bugs.python.org/issue29883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@1st1 1st1 1st1 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@asvetlov @1st1 @tirkarthi @auvipy @the-knights-who-say-ni @bedevere-bot @miss-islington @ameily