gh-131357: Add tests for zero-sized bytes objects in test_bytes.py by abstractedfox · Pull Request #134234 · python/cpython

abstractedfox · 2025-05-19T14:49:26Z

Concerns issue #131357 and adds slightly more descriptive comments for a few functions that crash when passed null

Issue: Add more tests for zero-sized bytes objects in capi tests #131357

python-cla-bot · 2025-05-19T14:49:30Z

All commit authors signed the Contributor License Agreement.

StanFromIreland

You need to sign the CLA.

Lib/test/test_capi/test_bytes.py

StanFromIreland · 2025-05-19T14:56:56Z

Lib/test/test_capi/test_bytes.py

+        self.assertTrue(check(b''))

-        # CRASHES check(NULL)
+        # CRASHES check(NULL) #PyBytes_CheckExact() expects PyObject*


How are these comments related? They should probably be on two lines.

Apologies; that was meant to explain why it crashes (it felt a little vague whether or not it was expected behavior). Would it be better on the next line, or in parenthesis or similar?

explain why it crashes

Then it should be on the same line, but without the #, as that makes it seem like 2 different notes.

StanFromIreland · 2025-05-19T17:16:00Z

Please do not click the "Update" button for no reason, see the devguide.

abstractedfox · 2025-05-19T17:29:55Z

Please do not click the "Update" button for no reason, see the devguide.

Oh, I apologize

Lib/test/test_capi/test_bytes.py

vstinner · 2025-05-19T20:52:54Z

I clicked on [Update branch] to try to repair the CI.

vstinner · 2025-05-19T21:52:38Z

Many CI fail with "cancelled", I don't know why :-(

CAM-Gerlach · 2025-05-19T23:08:31Z

@vstinner Myself and @webknjaz figured it out, its a longstanding issue with the concurrency group specifier in our workflow not sufficiently disambiguating PRs when multiple contributors submit a PR with the same branch name, in this case main. @abstractedfox will have a PR we assisted them on to fix this that should unblock this one.

vstinner · 2025-05-20T11:57:38Z

Close/reopen the PR to try to repair the CI.

vstinner · 2025-05-20T11:58:50Z

@vstinner Myself and @webknjaz figured it out, its a longstanding issue with the concurrency group specifier in our workflow not sufficiently disambiguating PRs when multiple contributors submit a PR with the same branch name, in this case main. @abstractedfox will have a PR we assisted them on to fix this that should unblock this one.

I suppose that it's this PR: #134310.

vstinner

LGTM

picnixz · 2025-05-20T15:24:40Z

@vstinner We backported the tests for bytesarray, do you want to backport those tests as well?

miss-islington-app · 2025-05-20T18:33:24Z

Thanks @abstractedfox for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2025-05-20T18:33:24Z

Thanks @abstractedfox for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

….py (pythonGH-134234) (cherry picked from commit 306f9e0) Co-authored-by: abstractedfox <coldcaption@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app · 2025-05-20T18:33:41Z

GH-134378 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-05-20T18:33:45Z

GH-134379 is a backport of this pull request to the 3.13 branch.

vstinner · 2025-05-20T18:34:22Z

@vstinner We backported the tests for bytesarray, do you want to backport those tests as well?

Sure. Let me backport these changes to 3.13 and 3.14 branches.

…s.py (GH-134234) (#134379) gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (GH-134234) (cherry picked from commit 306f9e0) Co-authored-by: abstractedfox <coldcaption@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

…s.py (GH-134234) (#134378) gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (GH-134234) (cherry picked from commit 306f9e0) Co-authored-by: abstractedfox <coldcaption@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

….py (python#134234) Co-authored-by: Victor Stinner <vstinner@python.org>

Add tests for zero-sized bytes objects in test_bytes.py

0bdb82d

bedevere-app bot added the tests Tests in the Lib/test dir label May 19, 2025

bedevere-app bot mentioned this pull request May 19, 2025

Add more tests for zero-sized bytes objects in capi tests #131357

Closed

This comment was marked as resolved.

Sign in to view

bedevere-app bot added the awaiting review label May 19, 2025

Merge branch 'main' into main

9fca2f1

This comment was marked as resolved.

Sign in to view

StanFromIreland reviewed May 19, 2025

View reviewed changes

Merge branch 'main' into main

f78a7d6

This comment was marked as resolved.

Sign in to view

ZeroIntensity added the skip news label May 19, 2025

abstractedfox and others added 4 commits May 19, 2025 11:26

Fix trailing whitespace

0d86737

Fix trailing whitespace

33e688a

Merge branch 'main' into main

48f11bf

Merge branch 'main' into main

2e25048

vstinner reviewed May 19, 2025

View reviewed changes

Lib/test/test_capi/test_bytes.py Outdated Show resolved Hide resolved

Lib/test/test_capi/test_bytes.py Outdated Show resolved Hide resolved

abstractedfox and others added 2 commits May 19, 2025 15:15

Reorder lines

570a334

Merge branch 'main' into main

545ecdb

abstractedfox mentioned this pull request May 20, 2025

gh-134309: Fix premature cancellation of CI tests when multiple PRs have the same branch name #134310

Merged

vstinner closed this May 20, 2025

vstinner reopened this May 20, 2025

vstinner approved these changes May 20, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels May 20, 2025

vstinner enabled auto-merge (squash) May 20, 2025 12:00

vstinner merged commit 306f9e0 into python:main May 20, 2025
67 of 76 checks passed

bedevere-app bot removed the awaiting merge label May 20, 2025

vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2025

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-131357: Add tests for zero-sized bytes objects in test_bytes…

698051a

….py (python#134234) Co-authored-by: Victor Stinner <vstinner@python.org>

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-131357: Add tests for zero-sized bytes objects in test_bytes…

fec4ead

….py (python#134234) Co-authored-by: Victor Stinner <vstinner@python.org>

Uh oh!

Conversation

abstractedfox commented May 19, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanFromIreland May 19, 2025

Choose a reason for hiding this comment

Uh oh!

abstractedfox May 19, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIreland May 19, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

StanFromIreland commented May 19, 2025

Uh oh!

abstractedfox commented May 19, 2025

Uh oh!

Uh oh!

Uh oh!

vstinner commented May 19, 2025

Uh oh!

vstinner commented May 19, 2025

Uh oh!

CAM-Gerlach commented May 19, 2025

Uh oh!

vstinner commented May 20, 2025

Uh oh!

vstinner commented May 20, 2025

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picnixz commented May 20, 2025

Uh oh!

miss-islington-app bot commented May 20, 2025

Uh oh!

miss-islington-app bot commented May 20, 2025

Uh oh!

bedevere-app bot commented May 20, 2025

Uh oh!

bedevere-app bot commented May 20, 2025

Uh oh!

vstinner commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abstractedfox commented May 19, 2025 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented May 19, 2025 •

edited

Loading