gh-133577: Add parameter formatter to logging.basicConfig#133578
Conversation
59777ee to
e7e2ccf
Compare
formatter_class to logging.basicConfigformatter to logging.basicConfig
ZeroIntensity
left a comment
There was a problem hiding this comment.
Needs a test and documentation update, not just the docstring.
| @@ -0,0 +1 @@ | |||
| Add parameter ``formatter`` to ``logging.basicConfig``. | |||
There was a problem hiding this comment.
| Add parameter ``formatter`` to ``logging.basicConfig``. | |
| Add parameter ``formatter`` to :func:`logging.basicConfig`. |
@ZeroIntensity thanks for your interest and I agree. I'm happy to take this to completion if there is buy-in from the CPython project. Before a new direction from @vsajip at #133577 any more changes here seems to be at risk of ending up in the trash can. Can you help me clear up the situation? Is this feature welcome or not? I would rather be sure first, and then go all in. |
|
I'm not at liberty to approve the feature, but I'm personally +1. I defer to @vsajip. |
I'll look favorably on the change where you pass in a formatter instance rather than a class, as that is more generally useful than your earlier suggestion. Please go ahead and update the documentation and tests, as suggested by @ZeroIntensity. |
|
@vsajip cool! Pushed, looking forward to your readme 🙏 |
0b80bc8 to
6454d34
Compare
Happy to make adjustments 🍻
logging.basicConfigshould support parameterformatter_class(currently instantiates hardcodedlogging.Formatter) #133577