Skip to content

gh-133210: Fix test_rlcompleter in --without-doc-strings mode#133332

Merged
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-133210-test_rlcompleter
May 3, 2025
Merged

gh-133210: Fix test_rlcompleter in --without-doc-strings mode#133332
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-133210-test_rlcompleter

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented May 3, 2025 •
edited by bedevere-app bot
Loading

This line affects the tests results:

cpython/Lib/rlcompleter.py

Line 106 in ac56f8c

if not inspect.signature(val).parameters:

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels May 3, 2025
@sobolevn sobolevn requested a review from vstinner May 3, 2025 08:24
@bedevere-app bedevere-app bot mentioned this pull request May 3, 2025
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 3, 2025
vstinner
vstinner reviewed May 3, 2025
View reviewed changes
vstinner
vstinner approved these changes May 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new code is more readable!

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented May 3, 2025

@vstinner thank you for your reviews!

@sobolevn sobolevn merged commit 881144f into python:main May 3, 2025
42 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented May 3, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 3, 2025
@sobolevn @miss-islington
pythongh-133210: Fix test_rlcompleter in --without-doc-strings mo…
f78adaf 
…de (pythonGH-133332)

(cherry picked from commit 881144f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented May 3, 2025

GH-133348 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 3, 2025
sobolevn added a commit that referenced this pull request May 3, 2025
@miss-islington @sobolevn
[3.13] gh-133210: Fix test_rlcompleter in --without-doc-strings m…
e090f8e 
…ode (GH-133332) (#133348)

gh-133210: Fix `test_rlcompleter` in `--without-doc-strings` mode (GH-133332)
(cherry picked from commit 881144f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-133210: Fix test_rlcompleter in --without-doc-strings mo…
2cb7730 
…de (python#133332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @vstinner