gh-132742: Improve tests for fcntl.ioctl() by serhiy-storchaka · Pull Request #132791 · python/cpython

serhiy-storchaka · 2025-04-22T06:52:47Z

~~Do not skip ALL ioctl() tests when /dev/tty is not available.~~ Done in other PR.
Use better tests for integer argument.
Add also parallel tests for tcflush() and tcflow().

Issue: Rewrite the fcntl module #132742

* Do not skip ALL ioctl() tests when /dev/tty is not available. * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow().

serhiy-storchaka · 2025-04-22T09:32:30Z

For some reasons tcflush() and tcflow() work differently on Linux/OpenIndiana vs BSD/macOS.

bedevere-bot · 2025-04-24T09:58:07Z

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 7efcbf9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132791%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

auvipy

looks good

miss-islington-app · 2025-04-28T07:43:04Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2025-04-28T07:43:19Z

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ed8e886f4f59df4eceefeb7eef2e3d146967df34 3.13

) * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow(). (cherry picked from commit ed8e886) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app · 2025-04-28T07:59:10Z

GH-133066 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2025-04-28T08:02:10Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit ed8e886.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2107) and take a look at the build logs.
Check if the failure is related to this commit (ed8e886) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2107

Failed tests:

test_ioctl
test_termios

Failed subtests:

test_tcflush_clear_input_or_output - test.test_termios.TestFunctions.test_tcflush_clear_input_or_output
test_ioctl_clear_input_or_output - test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'efABCDEF' != b'ABCDEF'


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line 164, in test_ioctl_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'

bedevere-bot · 2025-04-28T08:17:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Android 3.x (tier-3) has failed when building commit ed8e886.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1591/builds/1933) and take a look at the build logs.
Check if the failure is related to this commit (ed8e886) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1591/builds/1933

Failed tests:

test_ioctl
test_termios

Failed subtests:

test_tcflush_clear_input_or_output - test.test_termios.TestFunctions.test_tcflush_clear_input_or_output
test_ioctl_clear_input_or_output - test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'efABCDEF' != b'ABCDEF'


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line 164, in test_ioctl_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'

) * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow(). (cherry picked from commit ed8e886)

serhiy-storchaka · 2025-04-28T08:29:11Z

#133070 should fix the newly added tests on Android.

bedevere-bot · 2025-04-28T08:32:28Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x (tier-2) has failed when building commit ed8e886.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/338/builds/8637) and take a look at the build logs.
Check if the failure is related to this commit (ed8e886) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/338/builds/8637

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1079, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1021, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1079, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1021, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

vstinner · 2025-04-28T13:54:16Z

There are failures on "AMD64 Android 3.x" buildbot: https://buildbot.python.org/#/builders/1591/builds/1936

FAIL: test_ioctl_clear_input_or_output (test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line 164, in test_ioctl_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'

FAIL: test_tcflush_clear_input_or_output (test.test_termios.TestFunctions.test_tcflush_clear_input_or_output)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output
    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'ef' != b'ABCDEF'

@serhiy-storchaka:

#133070 should fix the newly added tests on Android.

Aha, let me see.

pythongh-132742: Improve tests for fcntl.ioctl()

a35e31e

* Do not skip ALL ioctl() tests when /dev/tty is not available. * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow().

bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 22, 2025

bedevere-app bot mentioned this pull request Apr 22, 2025

Rewrite the fcntl module #132742

Closed

serhiy-storchaka added 2 commits April 22, 2025 10:05

Add missed imports.

0dc4678

Fix some tests.

9647820

serhiy-storchaka marked this pull request as draft April 22, 2025 09:05

bedevere-app bot removed the awaiting core review label Apr 22, 2025

serhiy-storchaka added the skip news label Apr 22, 2025

serhiy-storchaka mentioned this pull request Apr 23, 2025

test_ioctl failing on MacOS #132843

Closed

serhiy-storchaka closed this Apr 23, 2025

Merge branch 'main' into test-ioctl2

2f4c329

serhiy-storchaka reopened this Apr 23, 2025

serhiy-storchaka added 3 commits April 23, 2025 23:27

Merge branch 'main' into test-ioctl2

0ed2f66

Fix tcflush() tests on BSD and OpenIndiana.

4698234

Skip tcflow() tests on non-Linux.

7efcbf9

serhiy-storchaka marked this pull request as ready for review April 24, 2025 09:57

bedevere-app bot added the awaiting core review label Apr 24, 2025

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2025

serhiy-storchaka added 2 commits April 24, 2025 19:09

Skip ioctl TCXONC tests on non-Linux.

86887c9

Merge branch 'main' into test-ioctl2

324bcfd

gpshead approved these changes Apr 27, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Apr 27, 2025

auvipy approved these changes Apr 28, 2025

View reviewed changes

serhiy-storchaka merged commit ed8e886 into python:main Apr 28, 2025
42 checks passed

bedevere-app bot removed the awaiting merge label Apr 28, 2025

serhiy-storchaka deleted the test-ioctl2 branch April 28, 2025 07:42

serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Apr 28, 2025

miss-islington-app bot assigned serhiy-storchaka Apr 28, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-132742: Improve tests for fcntl.ioctl()#132791

gh-132742: Improve tests for fcntl.ioctl()#132791
serhiy-storchaka merged 9 commits intopython:mainfrom
serhiy-storchaka:test-ioctl2

serhiy-storchaka commented Apr 22, 2025 •

edited

Loading

Uh oh!

serhiy-storchaka commented Apr 22, 2025

Uh oh!

bedevere-bot commented Apr 24, 2025

Uh oh!

auvipy left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Apr 28, 2025

Uh oh!

miss-islington-app bot commented Apr 28, 2025

Uh oh!

bedevere-app bot commented Apr 28, 2025

Uh oh!

bedevere-bot commented Apr 28, 2025

Uh oh!

bedevere-bot commented Apr 28, 2025

Uh oh!

serhiy-storchaka commented Apr 28, 2025

Uh oh!

bedevere-bot commented Apr 28, 2025

Uh oh!

vstinner commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

serhiy-storchaka commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Apr 22, 2025

Uh oh!

bedevere-bot commented Apr 24, 2025

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Apr 28, 2025

Uh oh!

miss-islington-app bot commented Apr 28, 2025

Uh oh!

bedevere-app bot commented Apr 28, 2025

Uh oh!

bedevere-bot commented Apr 28, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Apr 28, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

serhiy-storchaka commented Apr 28, 2025

Uh oh!

bedevere-bot commented Apr 28, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

vstinner commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-storchaka commented Apr 22, 2025 •

edited

Loading