Skip to content

bpo-36783: Add new references for C API Documentation changes#13204

Merged
matrixise merged 4 commits intopython:masterfrom
edison12a:fixup-bpo-36783
May 13, 2019
Merged

bpo-36783: Add new references for C API Documentation changes#13204
matrixise merged 4 commits intopython:masterfrom
edison12a:fixup-bpo-36783

Conversation

@edison12a
Copy link
Copy Markdown
Contributor

@edison12a edison12a commented May 8, 2019 •
edited by bedevere-bot
Loading

@edison12a edison12a changed the title Added new references for C API Documentation changes bpo-36783 Added new references for C API Documentation changes May 8, 2019
matrixise
matrixise reviewed May 8, 2019
View reviewed changes
Doc/c-api/datetime.rst
.. versionadded:: 3.6


.. c:function:: PyObject* PyTime_FromTime(int hour, int minute, int second, int usecond)
Copy link
Copy Markdown
Member

@matrixise matrixise May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you move this paragraph?

Copy link
Copy Markdown
Contributor Author

@edison12a edison12a May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved that paragraph to create a better order as requested by @pganssle so that PyTime_FromTimeAndFold follows PyTime_FromTime which is a better order for a user who will be reading the docs.

pganssle
pganssle reviewed May 8, 2019
View reviewed changes
Misc/NEWS.d/next/Documentation/2019-05-08-17-54-02.bpo-36783.Z9b3mL.rst Outdated
@@ -0,0 +1 @@
Add new references for C API Documentationadditions of Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold. Patch by Edison Abahurire.
Copy link
Copy Markdown
Member

@pganssle pganssle May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this blurb. @matrixise or someone can just add the "skip news" label, but this is just a fixup from the previous PR, which was merged a bit prematurely.

Copy link
Copy Markdown
Contributor Author

@edison12a edison12a May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pganssle
I have removed the blurb. Please review the change.
@matrixise

pganssle
pganssle approved these changes May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Edison!

@pganssle
Copy link
Copy Markdown
Member

pganssle commented May 8, 2019 •
edited
Loading

@matrixise @csabella Do one of you mind adding the "skip news" label? This is a fixup for the earlier PR, so it already has a corresponding blurb.

matrixise
matrixise approved these changes May 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@matrixise matrixise changed the title bpo-36783 Added new references for C API Documentation changes bpo-36783: Add new references for C API Documentation changes May 13, 2019
@matrixise matrixise merged commit d28772a into python:master May 13, 2019
@pganssle
Copy link
Copy Markdown
Member

pganssle commented May 13, 2019

@matrixise This needs a backport to Python 3.7 as well.

@pganssle
Copy link
Copy Markdown
Member

pganssle commented May 19, 2019

Ping @matrixise or @csabella - is it too late to add the "needs backport" label? The original change that this is a fixup for was backported to 3.7, but this PR wasn't.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 19, 2019

Thanks @SimiCode for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2019
@edison12a @miss-islington
bpo-36783: Add new references for C API Documentation changes (python…
00b8388 
…GH-13204)

(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 19, 2019

GH-13413 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 19, 2019
@miss-islington @edison12a
bpo-36783: Add new references for C API Documentation changes (GH-13204)
951b161 
(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
@edison12a edison12a deleted the fixup-bpo-36783 branch June 6, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes

@pganssle pganssle pganssle approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edison12a @pganssle @miss-islington @bedevere-bot @matrixise @the-knights-who-say-ni @csabella