Skip to content

bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold#13147

Merged
csabella merged 5 commits intopython:masterfrom
edison12a:bpo-36783
May 7, 2019
Merged

bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold#13147
csabella merged 5 commits intopython:masterfrom
edison12a:bpo-36783

Conversation

@edison12a
Copy link
Copy Markdown
Contributor

@edison12a edison12a commented May 7, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 7, 2019
@edison12a
Copy link
Copy Markdown
Contributor Author

edison12a commented May 7, 2019

@pganssle @Mariatta
I have added the requested documentation. Please review.

@mariatta-bot
Copy link
Copy Markdown

mariatta-bot commented May 7, 2019

Mariatta was mentioned, but she's out of open source from March 18th to May 9th, 2019 . Be aware she might not get to this until after PyCon US.
(I'm a bot)

@pganssle
Copy link
Copy Markdown
Member

pganssle commented May 7, 2019

This can be backported to at least 3.7.

csabella
csabella approved these changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@csabella csabella merged commit 5765ecf into python:master May 7, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 7, 2019

Thanks @SimiCode for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2019
@edison12a @miss-islington
bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyD…
fde2574 
…ateTime_FromDateAndTimeAndFold (pythonGH-13147)

(cherry picked from commit 5765ecf)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 7, 2019

GH-13156 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 7, 2019
@miss-islington @edison12a
bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyD…
146010e 
…ateTime_FromDateAndTimeAndFold (GH-13147)

(cherry picked from commit 5765ecf)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
@SidhdhARTH
Copy link
Copy Markdown

SidhdhARTH commented May 28, 2019

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@edison12a @mariatta-bot @pganssle @miss-islington @bedevere-bot @SidhdhARTH @csabella @the-knights-who-say-ni