Skip to content

bpo-11001: updated cookie docs#13086

Merged
miss-islington merged 2 commits intopython:masterfrom
Julsy:fix-issue-11001
May 7, 2019
Merged

bpo-11001: updated cookie docs#13086
miss-islington merged 2 commits intopython:masterfrom
Julsy:fix-issue-11001

Conversation

@Julsy
Copy link
Copy Markdown
Contributor

@Julsy Julsy commented May 4, 2019 •
edited by bedevere-bot
Loading

Used spookylukey's patch from 2011-01-24

https://bugs.python.org/issue11001

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented May 4, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 4, 2019
@gpshead gpshead self-assigned this May 4, 2019
tirkarthi
tirkarthi reviewed May 5, 2019
View reviewed changes
eamanu
eamanu reviewed May 6, 2019
View reviewed changes
gpshead
gpshead approved these changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Julsy !

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 7, 2019

@Julsy: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 91cc01f into python:master May 7, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 7, 2019

Thanks @Julsy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2019
@Julsy @miss-islington
bpo-11001: updated cookie docs (pythonGH-13086)
735427f 
Used **spookylukey**'s patch from 2011-01-24

https://bugs.python.org/issue11001
(cherry picked from commit 91cc01f)

Co-authored-by: Julia Iliuk <julia.iluyk@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 7, 2019

GH-13161 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 7, 2019
@miss-islington
[3.7] bpo-11001: updated cookie docs (GH-13086) (GH-13161)
1fe722c 
Used **spookylukey**'s patch from 2011-01-24



https://bugs.python.org/issue11001
(cherry picked from commit 91cc01f)


Co-authored-by: Julia Iliuk <julia.iluyk@gmail.com>


https://bugs.python.org/issue11001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@eamanu eamanu eamanu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Julsy @the-knights-who-say-ni @miss-islington @bedevere-bot @gpshead @tirkarthi @eamanu