Skip to content

gh-130145: fix loop.run_forever when loop is already running#130146

Merged
kumaraditya303 merged 3 commits intopython:mainfrom
kumaraditya303:bugfix
Feb 15, 2025
Merged

gh-130145: fix loop.run_forever when loop is already running#130146
kumaraditya303 merged 3 commits intopython:mainfrom
kumaraditya303:bugfix

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 commented Feb 15, 2025

@kumaraditya303 kumaraditya303 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes topic-asyncio type-bug An unexpected behavior, bug, or error labels Feb 15, 2025
@kumaraditya303
Copy link
Copy Markdown
Contributor Author

Merging as the fix is trivial.

@kumaraditya303 kumaraditya303 merged commit a545749 into python:main Feb 15, 2025
@miss-islington-app
Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the bugfix branch February 15, 2025 09:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2025
…ythonGH-130146)

(cherry picked from commit a545749)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@miss-islington-app
Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a545749b0e6c56cab853c5c8df3c199b9707994f 3.12

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Feb 15, 2025

GH-130147 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 15, 2025
kumaraditya303 added a commit that referenced this pull request Feb 15, 2025
…GH-130146) (#130147)

gh-130145: fix `loop.run_forever` when loop is already running (GH-130146)
(cherry picked from commit a545749)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Feb 25, 2025

Sorry, @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker a545749b0e6c56cab853c5c8df3c199b9707994f 3.12

@kumaraditya303 https://github.com/python/cpython/blob/3.12/Lib/asyncio/base_events.py has no _run_forever_setup(), so no need for 3.12 backport? Let's remove the label if so.

@kumaraditya303 kumaraditya303 removed the needs backport to 3.12 only security fixes label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants