gh-129363: Change regrtest sequential mode output#129476
Merged
vstinner merged 2 commits intopython:mainfrom Feb 21, 2025
Merged
gh-129363: Change regrtest sequential mode output#129476vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice.
Member
Author
Member
|
This is an improvement but will double the length of the logs. Shall we take inspiration from pytest, which first prints the (uncoloured) name of the test, and then appends the coloured result? 
So we could do it something like this? 
|
Member
Author
Currently, when a test fails, it's output is written directly. So we cannot just add "passed" or "failed" after running a test. Example (I added a bug to test_os): |
Member
Author
|
I wrote #129687 instead, I abandon this PR. |
Member
Author
|
@hugovk prefers this PR, so I reopen it. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 21, 2025
) First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice. (cherry picked from commit f1b81c4) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-130405 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 21, 2025
) First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice. (cherry picked from commit f1b81c4) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-130406 is a backport of this pull request to the 3.12 branch. |
vstinner
added a commit
that referenced
this pull request
Feb 21, 2025
…130406) gh-129363: Change regrtest sequential mode output (GH-129476) First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice. (cherry picked from commit f1b81c4) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
vstinner
added a commit
that referenced
this pull request
Feb 21, 2025
…130405) gh-129363: Change regrtest sequential mode output (GH-129476) First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice. (cherry picked from commit f1b81c4) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, write the test name without color. Then, write the test name and the result with color. Each test is displayed twice.
Example:
python -m testcolor print with and without-j#129363