GH-124483: Mark Py_DECREF, etc. as escaping for the JIT#128678
Merged
markshannon merged 8 commits intopython:mainfrom Jan 13, 2025
Merged
GH-124483: Mark Py_DECREF, etc. as escaping for the JIT#128678markshannon merged 8 commits intopython:mainfrom
Py_DECREF, etc. as escaping for the JIT#128678markshannon merged 8 commits intopython:mainfrom
Conversation
Py_DECREF, etc. as escaping for tier 1Py_DECREF, etc. as escaping for tier 1
Py_DECREF, etc. as escaping for tier 1Py_DECREF, etc. as escaping for the JIT
iritkatriel
reviewed
Jan 13, 2025
iritkatriel
approved these changes
Jan 13, 2025
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Member
|
@markshannon, I think we also need to handle
An alternative that we discussed is to make the steal-y things only steal on success, and we count on the error handler to pop things otherwise., since it would be a shame if returning a tuple was an "escaping" operation. We could probably also do something similar for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike #124615 this doesn't change tier 1 or GC behavior at all.
This ensures correctness of tier 2 without any potential breakage.
We will want to handle
Py_DECREFetc. in a more sophisticated way in the future, to improve GC and enable refcounting optimizations. For now though, this fixes the bug in tier2._Py_Deallocis an escaping call #124483