gh-127359: Pin Tcl/Tk to 8 (8.6) for testing macOS#127365
gh-127359: Pin Tcl/Tk to 8 (8.6) for testing macOS#127365hugovk merged 3 commits intopython:mainfrom
Conversation
| run: brew install pkg-config openssl@3.0 xz gdbm tcl-tk make | ||
| run: | | ||
| brew install pkg-config openssl@3.0 xz gdbm tcl-tk@8 make | ||
| brew link tcl-tk@8 |
There was a problem hiding this comment.
I don't know brew: what is this new brew link tcl-tk@8 command? brew install is not enough? Maybe add a comment to explain it?
There was a problem hiding this comment.
Because tcl-tk@8 is an alternative version and not the latest, it installs as so-called "keg-only", which means it doesn't get symlinked into the usual paths:
❯ brew info tcl-tk@8
==> tcl-tk@8: stable 8.6.15 (bottled) [keg-only]
Tool Command Language
https://www.tcl-lang.org
Installed
/opt/homebrew/Cellar/tcl-tk@8/8.6.15 (3,069 files, 35.7MB)
Poured from bottle using the formulae.brew.sh API on 2024-11-28 at 14:38:32
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/t/tcl-tk@8.rb
License: TCL
==> Dependencies
Required: openssl@3 ✔
==> Caveats
The sqlite3_analyzer binary is in the `sqlite-analyzer` formula.
tcl-tk@8 is keg-only, which means it was not symlinked into /opt/homebrew,
because this is an alternate version of another formula.
If you need to have tcl-tk@8 first in your PATH, run:
echo 'export PATH="/opt/homebrew/opt/tcl-tk@8/bin:$PATH"' >> ~/.zshrc
For compilers to find tcl-tk@8 you may need to set:
export LDFLAGS="-L/opt/homebrew/opt/tcl-tk@8/lib"
export CPPFLAGS="-I/opt/homebrew/opt/tcl-tk@8/include"
For pkg-config to find tcl-tk@8 you may need to set:
export PKG_CONFIG_PATH="/opt/homebrew/opt/tcl-tk@8/lib/pkgconfig"
==> Analytics
install: 12,709 (30 days), 12,737 (90 days), 12,738 (365 days)
install-on-request: 280 (30 days), 310 (90 days), 310 (365 days)
build-error: 8 (30 days)Perhaps a comment like?
brew install pkg-config openssl@3.0 xz gdbm tcl-tk@8 make
# Because alternate versions are not symlinked into place by default:
brew link tcl-tk@8
vstinner
left a comment
There was a problem hiding this comment.
LGTM. You might add a comment on brew link or not, it's up to you.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @hugovk, I could not cleanly backport this to |
|
Sorry, @hugovk, I could not cleanly backport this to |
(cherry picked from commit b83be9c)
|
GH-127393 is a backport of this pull request to the 3.13 branch. |
|
GH-127394 is a backport of this pull request to the 3.12 branch. |
…onGH-127365) (cherry picked from commit b83be9c) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, @hugovk, I could not cleanly backport this to |
|
Sorry, @hugovk, I could not cleanly backport this to |
|
Sorry, @hugovk, I could not cleanly backport this to |
|
GH-127407 is a backport of this pull request to the 3.11 branch. |
|
GH-127408 is a backport of this pull request to the 3.10 branch. |
|
GH-127409 is a backport of this pull request to the 3.9 branch. |
Uh oh!
There was an error while loading. Please reload this page.