Skip to content

bpo-36050: optimize HTTPResponse.read() #12698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 1 commit into from
Apr 6, 2019
Merged

bpo-36050: optimize HTTPResponse.read() #12698

methane merged 1 commit into from
Apr 6, 2019

Conversation

@methane
Copy link
Member

@methane methane commented Apr 5, 2019 •
edited by bedevere-bot
Loading

  • No need to split read
  • No need to partial read caused by EINTR

https://bugs.python.org/issue36050

@methane
bpo-36050: optimize HTTPResponse.read()
8faab59 
* No need to chunking for now.
* No need to partial read caused by EINTR for now.
@methane methane added performance Performance or resource usage awaiting core review labels Apr 5, 2019
@vadmium
Copy link
Member

vadmium commented Apr 6, 2019

This looks good to me, Inada.

@methane methane merged commit d6bf6f2 into python:master Apr 6, 2019
@methane methane deleted the bpo36050-httpclient branch April 11, 2019 08:28
@admackin
Copy link

admackin commented Jun 24, 2021

FYI: this change has caused a regression in HTTP response under SSL resulting in inability to read files > 2 GiB over SSL: https://bugs.python.org/issue42853 .

Is there some reason we can't move back to eg 1GB chunks in MAXAMOUNT as a sane middle ground instead of 1MiB (old) or infinite (new)?

methane added a commit to methane/cpython that referenced this pull request Jul 28, 2021
@methane
Revert "bpo-36050: optimize HTTPResponse.read() (pythonGH-12698)"
ae92a06 
This reverts commit d6bf6f2.
ambv pushed a commit that referenced this pull request Jul 28, 2021
@methane
[3.9] bpo-42853: Fix http.client fails to download >2GiB data over TLS (
153365d 
GH-27405)

Revert "bpo-36050: optimize HTTPResponse.read() (GH-12698)"

This reverts commit d6bf6f2.
@jthetzel jthetzel mentioned this pull request Jan 12, 2022
Closed
@bmerry bmerry mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@methane @vadmium @admackin @the-knights-who-say-ni @bedevere-bot