Skip to content

bpo-36527: silence -Wunused-parameter warnings in object.h #12688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 1 commit into from
Apr 6, 2019
Merged

bpo-36527: silence -Wunused-parameter warnings in object.h #12688

methane merged 1 commit into from
Apr 6, 2019

Conversation

@AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Apr 4, 2019 •
edited by bedevere-bot
Loading

Fix -Wunused-parameter warnings in object.h, as these show up when building third party code and may lead to build failures with -Werror.

https://bugs.python.org/issue36527

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 4, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

methane
methane reviewed Apr 5, 2019
View reviewed changes
@methane methane merged commit a0da131 into python:master Apr 6, 2019
@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Apr 8, 2019

Thanks! Is there something needed to get this merged into 3.8?

@methane
Copy link
Member

methane commented Apr 9, 2019

It is merged to 3.8 already. Do you mean 3.7?

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Apr 9, 2019

It is merged to 3.8 already. Do you mean 3.7?

I've meant 3.8, I see now it was merged. Thanks again!

@AMDmi3 AMDmi3 deleted the fix-issue-36527 branch April 9, 2019 12:41
AMDmi3 added a commit to AMDmi3/jsonslicer that referenced this pull request Apr 9, 2019
@AMDmi3
Unallow failures with python 3.8+, python warnings were fixed
31cda36 
See https://bugs.python.org/issue36527 and python/cpython#12688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AMDmi3 @the-knights-who-say-ni @methane @bedevere-bot