gh-126084: Fix venvwlauncher to run pythonw#126088
Conversation
70569a3 to
b08755a
Compare
|
This is user-facing, so it needs a NEWS entry, per the bot. Probably needs a test too. Also, for future reference, don't force push--it makes the review process more difficult. Everything is squash merged at the end anyway. |
cfe2498 to
040e6f9
Compare
040e6f9 to
58f9d7a
Compare
|
That test works fine locally. What could be different about the CI environment? |
And perhaps make it work on GitHub ...
|
So it's not the realpath(). I don't want to waste massive amounts of time and energy by probing around the CI environment and running the whole lot each time. Any suggestions? |
|
Locally for me, |
It is supposed to return the path to the executable for the current process.
No: When in a venv, One moment please ... |
|
This one should work in release and debug, but I'm curious to see whether it works in the GIL-less builds. [Update: It does. The specific requirement is that the "w" immediately follows the "python" in the file name.] |
|
Thanks for finding and fixing this! What a silly mistake (probably mine...) |
|
Thanks @chrullrich for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @chrullrich and @zooba, I could not cleanly backport this to |
|
GH-126142 is a backport of this pull request to the 3.13 branch. |
|
Doesn't apply to 3.12, only 3.13. |
Fixes #126084