bpo-36440: include node names in ParserError messages, instead of numeric IDs #12565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Mar 26, 2019
Misc/NEWS.d/next/Core and Builtins/2019-03-25-13-45-19.bpo-36440.gkvzhi.rst
Outdated
Show resolved
Hide resolved
pablogsal
reviewed
Mar 26, 2019
Member
|
You have some trailing whitespace in |
7de4a23 to
f6601c5
Compare
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
What if the index out of the boundary of the array?
f6601c5 to
127ff2f
Compare
Contributor
Author
Fixed |
127ff2f to
e204705
Compare
e204705 to
19ced03
Compare
serhiy-storchaka
approved these changes
Mar 28, 2019
Contributor
Author
|
@pablogsal do you have any unresolved comments regarding this patch? |
pablogsal
approved these changes
Apr 3, 2019
Member
|
@tyomitch Thanks for the ping and sorry for the delay! |
Contributor
|
Thanks @tyomitch for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Contributor
|
Sorry, @tyomitch and @pablogsal, I could not cleanly backport this to |
|
GH-12671 is a backport of this pull request to the 3.7 branch. |
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Apr 3, 2019
…of numeric IDs (pythonGH-12565) The error messages in the parser module are referring to numeric IDs for the nodes. To improve readability, use the node names when reporting errors.. (cherry picked from commit cb0748d) Co-authored-by: tyomitch <tyomitch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36440