Skip to content

bpo-36416: Correct bytes.rpartition documentation#12543

Merged
methane merged 1 commit intopython:masterfrom
pewscorner:fix-issue-36416
Apr 11, 2019
Merged

bpo-36416: Correct bytes.rpartition documentation#12543
methane merged 1 commit intopython:masterfrom
pewscorner:fix-issue-36416

Conversation

@pewscorner
Copy link
Copy Markdown
Contributor

@pewscorner pewscorner commented Mar 25, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Mar 25, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 25, 2019
eamanu
eamanu approved these changes Mar 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please sign CLA

tirkarthi
tirkarthi approved these changes Mar 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catch.

@pewscorner
Copy link
Copy Markdown
Contributor Author

pewscorner commented Mar 27, 2019

CLA signed. :-)

@methane methane merged commit efc4870 into python:master Apr 11, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 11, 2019

Thanks @pewscorner for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 11, 2019

Thanks @pewscorner for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2019
@pewscorner @miss-islington
bpo-36416: Correct bytes.rpartition documentation (pythonGH-12543)
ca5ccc0 
(cherry picked from commit efc4870)

Co-authored-by: pewscorner <pewscorner@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 11, 2019

GH-12781 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 11, 2019
@miss-islington @pewscorner
bpo-36416: Correct bytes.rpartition documentation (GH-12543)
04b114e 
(cherry picked from commit efc4870)

Co-authored-by: pewscorner <pewscorner@users.noreply.github.com>
@pewscorner pewscorner deleted the fix-issue-36416 branch April 12, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@pewscorner @the-knights-who-say-ni @miss-islington @bedevere-bot @rhettinger @tirkarthi @eamanu @methane @csabella