bpo-35941: Fix ssl certificate enumeration for windows #12486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a function that collects certificates from several certificate stores into one certificate collection store that is enumerated.
This commit adds a function that collects certificates from several certificate stores into one certificate collection store that is enumerated.
…ssue-35941 Reopen PR for "bpo-35941: Fix ssl certificate enumeration for windows"
Member
|
@kctherookie Sorry for the delay again - we'll want the NEWS file for this item, since it's a valuable fix that people should know about. Could you add it? There are instructions if you click "Details" on the failed check below. |
Contributor
Author
|
Added NEWS entry, thanks for reviewing. |
Contributor
|
Thanks @kctherookie for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Member
|
Thanks for the contribution! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2019
Add a function to collect certificates from several certificate stores into one certificate collection store that is then enumerated. This ensures we load as many certificates as we can access. (cherry picked from commit d93fbbf) Co-authored-by: kctherookie <48805853+kctherookie@users.noreply.github.com>
|
GH-12609 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 28, 2019
Add a function to collect certificates from several certificate stores into one certificate collection store that is then enumerated. This ensures we load as many certificates as we can access. (cherry picked from commit d93fbbf) Co-authored-by: kctherookie <48805853+kctherookie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to Modules/_ssl.c.
The function collects all readable certificate stores into one certificate store collection that is later
used by _ssl_enum_certificates_impl and _ssl_enum_crls_impl. During enumeration duplicate certificates and crls are handled.
Reopened PR for @zooba
https://bugs.python.org/issue35941