gh-58282: Fix support of tuple metavar for positional arguments in argparse#124782
Merged
serhiy-storchaka merged 1 commit intopython:mainfrom Oct 2, 2024
Merged
Conversation
… in argparse Previously, formatting help output or error message for positional argument with a tuple metavar raised exception. Co-authored-b: Cyker Way <cykerway@gmail.com>
30a33a6 to
b24aa03
Compare
This was referenced Sep 30, 2024
savannahostrowski
approved these changes
Oct 1, 2024
Member
savannahostrowski
left a comment
There was a problem hiding this comment.
I think this looks good to me. Thanks for adding so many test cases!
Member
Author
|
Thank you for your review, @savannahostrowski. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 2, 2024
… in argparse (pythonGH-124782) Previously, formatting help output or error message for positional argument with a tuple metavar raised exception. (cherry picked from commit 9b31a2d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Cyker Way <cykerway@gmail.com>
|
GH-124881 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 2, 2024
…guments in argparse (pythonGH-124782) Previously, formatting help output or error message for positional argument with a tuple metavar raised exception. (cherry picked from commit 9b31a2d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Cyker Way <cykerway@gmail.com>
|
GH-124882 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, formatting help output or error message for positional argument with a tuple metavar raised exception.
Co-authored-by: Cyker Way cykerway@gmail.com