gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint#124454
Merged
gaogaotiantian merged 5 commits intopython:mainfrom Oct 15, 2024
Merged
Conversation
iritkatriel
reviewed
Sep 30, 2024
| @@ -0,0 +1 @@ | |||
| Setting a :mod:`pdb` breakpoint on a function that's already in the call stack will enable the trace function on that frame so the breakpoint would trigger. | |||
Member
There was a problem hiding this comment.
This can probably be reworded to make it clearer what the change is (e.g., "Fix bug where..."). They way it's written it's not immediately clear what the old vs new behaviour is.
Member
Author
There was a problem hiding this comment.
Ah, missed that. Do you think the current news is better?
iritkatriel
reviewed
Sep 30, 2024
iritkatriel
reviewed
Oct 15, 2024
Misc/NEWS.d/next/Library/2024-09-24-18-16-59.gh-issue-58956.0wFrBR.rst
Outdated
Show resolved
Hide resolved
…FrBR.rst Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel
approved these changes
Oct 15, 2024
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2024
…a new breakpoint (pythonGH-124454) (cherry picked from commit 12eaadc) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2024
…a new breakpoint (pythonGH-124454) (cherry picked from commit 12eaadc) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
|
GH-125548 is a backport of this pull request to the 3.13 branch. |
|
GH-125549 is a backport of this pull request to the 3.12 branch. |
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
gaogaotiantian
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2025
…a new breakpoint (pythonGH-124454) (cherry picked from commit 12eaadc) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.