gh-123560: correct docs for "empty" format type for floats#123561
Merged
vstinner merged 2 commits intopython:mainfrom Sep 26, 2024
Merged
gh-123560: correct docs for "empty" format type for floats#123561vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
Member
Author
Member
|
I'll have a look at it tomorrow afternoon or in the week-end. I need to read your issue as well. |
picnixz
reviewed
Sep 25, 2024
picnixz
approved these changes
Sep 25, 2024
vstinner
approved these changes
Sep 26, 2024
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I can see differences:
>>> format(1.0, '') # at least one digit past dot
'1.0'
>>> format(1.0, 'g')
'1'
>>> format(1.2345e10, '')
'12345000000.0'
>>> format(1.2345e10, 'g')
'1.2345e+10'
|
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2024
…honGH-123561) (cherry picked from commit 274d9ab) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
|
GH-124596 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2024
…honGH-123561) (cherry picked from commit 274d9ab) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
|
GH-124597 is a backport of this pull request to the 3.12 branch. |
Member
|
Merged. Thanks @skirpichev and @picnixz. |
vstinner
pushed a commit
that referenced
this pull request
Sep 26, 2024
Yhg1s
pushed a commit
that referenced
this pull request
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--123561.org.readthedocs.build/