Skip to content

[3.6] bpo-35647: Fix path check in cookiejar (GH-11436) #12268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ned-deily merged 1 commit into from
Mar 12, 2019
Merged

[3.6] bpo-35647: Fix path check in cookiejar (GH-11436) #12268

ned-deily merged 1 commit into from
Mar 12, 2019

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 10, 2019 •
edited by bedevere-bot
Loading

  • Refactor cookie path check as per RFC 6265

  • Add tests for prefix match of path

  • Add news entry

  • Fix set_ok_path and refactor tests

  • Use slice for last letter
    (cherry picked from commit 0e1f1f0)

Co-authored-by: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue35647

@tirkarthi @miss-islington
bpo-35647: Fix path check in cookiejar (pythonGH-11436)
2148f8d 
* Refactor cookie path check as per RFC 6265

* Add tests for prefix match of path

* Add news entry

* Fix set_ok_path and refactor tests

* Use slice for last letter
(cherry picked from commit 0e1f1f0)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 10, 2019
Merged
@orsenthil orsenthil self-requested a review March 10, 2019 17:16
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 10, 2019

@tirkarthi and @orsenthil: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 10, 2019

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@orsenthil orsenthil requested a review from ned-deily March 10, 2019 17:41
@ned-deily ned-deily merged commit 5565b1d into python:3.6 Mar 12, 2019
@miss-islington miss-islington deleted the backport-0e1f1f0-3.6 branch March 12, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @orsenthil @ned-deily @the-knights-who-say-ni @bedevere-bot @tirkarthi