bpo-36176: Fix IDLE autocomplete & calltip popup colors. #12262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent conflicts with Linux dark themes (and slightly darken calltip background).
csabella
approved these changes
Mar 10, 2019
Contributor
csabella
left a comment
There was a problem hiding this comment.
Tested on Ubuntu Gnome light and dark and KDE light and dark and the autocomplete and calltips are viewable on all 4 combinations.
|
@terryjreedy: Please replace |
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-12269 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2019
) Prevent conflicts with Linux dark themes (and slightly darken calltip background). (cherry picked from commit 491ef53) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
https://bugs.python.org/issue36176