Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 9, 2019

Incorrect issue number '13210' added in 539ee5d.

https://bugs.python.org/issue13120

It was added in 539ee5d, and should have the correct name.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 9, 2019
@blueyed blueyed changed the title tests: fix typo with test_issue13120 bpo-13120: fix typo with test_issue13120 Mar 9, 2019
Copy link
Contributor

@rougeth rougeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettcannon brettcannon changed the title bpo-13120: fix typo with test_issue13120 bpo-13120: fix typo with test_issue13120() method name Apr 1, 2019
@brettcannon
Copy link
Member

Thanks everyone! Assuming CI passes this will be automatically committed.

@miss-islington
Copy link
Contributor

@blueyed: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9139f92 into python:master Apr 1, 2019
@miss-islington
Copy link
Contributor

Thanks @blueyed for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12652 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2019
Incorrect issue number '13210' added in 539ee5d.

https://bugs.python.org/issue13120
(cherry picked from commit 9139f92)

Co-authored-by: Daniel Hahler <github@thequod.de>
@blueyed blueyed deleted the fix-test-name branch April 1, 2019 23:42
miss-islington added a commit that referenced this pull request Apr 2, 2019
Incorrect issue number '13210' added in 539ee5d.

https://bugs.python.org/issue13120
(cherry picked from commit 9139f92)

Co-authored-by: Daniel Hahler <github@thequod.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants